Release JNI event listener array elements - #15053
Open
fyrsta7 wants to merge 1 commit into
Open
Conversation
fyrsta7
marked this pull request as ready for review
August 8, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14972 by releasing the
jlongArrayelements acquired while copying Java event listeners into native shared pointers.Details
rocksdb_set_event_listeners_helpercallsGetLongArrayElementsto read the listener handles, but did not release the returned pointer after copying the values. This adds the matchingReleaseLongArrayElementscall withJNI_ABORT, since the native code does not modify the Java array.Validation
I built RocksJava and ran the repository's Java test runner with JNI checking enabled:
OptionsTest(141 tests),DBOptionsTest(84 tests), and the runner'sStatisticsTest(8 tests) all passed with no failures or errors. Both options test classes exercisesetListenersandlisteners, including replacing a non-empty listener list with an empty list.