Fix MSVC C4702 warnings in trie index factory - #15090
Open
jeongseok-meta wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the two
return nullptrstatements that follow unconditionalabort()calls in the deprecatedTrieIndexFactoryoverloads.Why
These overloads are intentionally non-returning, as documented by their existing comments. MSVC diagnoses each trailing return as unreachable code (C4702), which breaks Windows builds when warnings are treated as errors. Since
abort()is non-returning, deleting the unreachable statements preserves the intended behavior and keeps warning-as-error coverage intact.This was found while packaging RocksDB 11.8.1 for conda-forge. I searched the current RocksDB issues and pull requests for C4702, unreachable-code, and trie-index fixes and found no existing report or patch; current
mainstill contains both returns.Validation
git diff --check