Remove stale reference to removed folly SplitStringSimd.cpp - #244
Open
rootkiller6788 wants to merge 1 commit into
Open
Remove stale reference to removed folly SplitStringSimd.cpp#244rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
folly removed folly/detail/SplitStringSimd.cpp (fbcode D85101083); the implementation now lives header-only in SplitStringSimdImpl.h. The CMakeLists.txt source list still referenced the non-existent file, which made CMake fail at configure time with "Cannot find source file: .../folly/detail/SplitStringSimd.cpp" when building against a recent folly checkout. Fixes facebook#242.
rootkiller6788
marked this pull request as ready for review
August 29, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #242.
CMakeLists.txtlisted${FOLLY_SOURCE_DIR}/folly/detail/SplitStringSimd.cppin theFOLLY_CPP_SRCset, but folly removed that translation unit on 2025-10-27 (fbcode D85101083, "allow all container and string types in split()").The split() implementation moved into headers:
folly/detail/SplitStringSimd.hnow includesfolly/detail/SplitStringSimdImpl.h, which is fully header-only (all templates,FOLLY_NOINLINE/FOLLY_ALWAYS_INLINE). No link-time symbol from a.cppis needed by wdt's use offolly::split(e.g.wdtCmdLine.cppsplits on'\t'via the header-onlysimdSplitByChar).Keeping the stale entry makes CMake fail at configure time against a current folly checkout:
This removes the stale entry. All other folly sources in
FOLLY_CPP_SRCstill exist in follymain(verified against the folly git tree).Verification
folly/detail/SplitStringSimd.cppis absent from folly's currentmaintree (404 via the contents API), whileSplitStringSimd.h/SplitStringSimdImpl.hremain..cppfiles inFOLLY_CPP_SRCexist in follymain.folly::split('\t', ...)inwdtCmdLine.cpp) resolves via the header-only implementation.Test plan
N/A — CMake source-list change; configure succeeds once the non-existent file is removed.