Skip to content

Remove stale reference to removed folly SplitStringSimd.cpp - #244

Open
rootkiller6788 wants to merge 1 commit into
facebook:mainfrom
rootkiller6788:fix-remove-stale-splitstring-simd
Open

Remove stale reference to removed folly SplitStringSimd.cpp#244
rootkiller6788 wants to merge 1 commit into
facebook:mainfrom
rootkiller6788:fix-remove-stale-splitstring-simd

Conversation

@rootkiller6788

Copy link
Copy Markdown

Summary

Closes #242.

CMakeLists.txt listed ${FOLLY_SOURCE_DIR}/folly/detail/SplitStringSimd.cpp in the FOLLY_CPP_SRC set, but folly removed that translation unit on 2025-10-27 (fbcode D85101083, "allow all container and string types in split()").

The split() implementation moved into headers: folly/detail/SplitStringSimd.h now includes folly/detail/SplitStringSimdImpl.h, which is fully header-only (all templates, FOLLY_NOINLINE/FOLLY_ALWAYS_INLINE). No link-time symbol from a .cpp is needed by wdt's use of folly::split (e.g. wdtCmdLine.cpp splits on '\t' via the header-only simdSplitByChar).

Keeping the stale entry makes CMake fail at configure time against a current folly checkout:

CMake Error at CMakeLists.txt:79: Cannot find source file:
  .../folly/detail/SplitStringSimd.cpp

This removes the stale entry. All other folly sources in FOLLY_CPP_SRC still exist in folly main (verified against the folly git tree).

Verification

  • Confirmed folly/detail/SplitStringSimd.cpp is absent from folly's current main tree (404 via the contents API), while SplitStringSimd.h / SplitStringSimdImpl.h remain.
  • Confirmed all other 9 folly .cpp files in FOLLY_CPP_SRC exist in folly main.
  • Confirmed wdt's only use of char-splitting (folly::split('\t', ...) in wdtCmdLine.cpp) resolves via the header-only implementation.

Test plan

N/A — CMake source-list change; configure succeeds once the non-existent file is removed.

folly removed folly/detail/SplitStringSimd.cpp (fbcode D85101083);
the implementation now lives header-only in SplitStringSimdImpl.h.
The CMakeLists.txt source list still referenced the non-existent
file, which made CMake fail at configure time with
"Cannot find source file: .../folly/detail/SplitStringSimd.cpp"
when building against a recent folly checkout.

Fixes facebook#242.
@meta-cla meta-cla Bot added the CLA Signed label Aug 21, 2026
@rootkiller6788
rootkiller6788 marked this pull request as ready for review August 29, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SplitStringSimd.cpp no longer in folly but listed in wdt's CMakeLists.txt

1 participant