lore: keep hourly lore refreshes from growing the database without bound

Cargo.toml

@@ -66,6 +66,11 @@ chrono = "0.4.44"
 chrono-english = "0.1"  # Natural language date parsing
 base64 = "0.22"         # Base64 decoding for MIME-encoded email bodies
 
+[dev-dependencies]
+# Tests reach lance's WriteParams, which lancedb does not re-export.  Pin
+# the exact version lancedb resolves to, so the two cannot drift apart.
+lance = { version = "=4.0.0", default-features = false }
+
 [[bin]]
 name = "semcode-index"
 path = "src/bin/index.rs"

src/bin/index.rs

@@ -1202,7 +1202,8 @@ async fn main() -> Result<()> {
                 // combined working set triggers the OOM killer.
                 println!("\nCompacting lore tables...");
                 match db_manager.compact_lore_tables().await {
-                    Ok(_) => println!("Lore table compaction completed successfully"),
+                    Ok(true) => println!("Lore table compaction completed successfully"),
+                    Ok(false) => {}
                     Err(e) => error!("Failed to compact lore tables: {}", e),
                 }
 
@@ -1216,7 +1217,8 @@ async fn main() -> Result<()> {
                     Err(e) => eprintln!("Warning: Failed to ensure FTS indices: {}", e),
                 }
                 match db_manager.optimize_lore_fts_indices().await {
-                    Ok(_) => println!("FTS indices updated successfully"),
+                    Ok(true) => println!("FTS indices updated successfully"),
+                    Ok(false) => {}
                     Err(e) => eprintln!("Warning: Failed to optimize FTS indices: {}", e),
                 }
             }
@@ -1376,7 +1378,8 @@ async fn main() -> Result<()> {
             if total_new_emails > 0 {
                 println!("\nCompacting lore tables...");
                 match db_manager.compact_lore_tables().await {
-                    Ok(_) => println!("Lore table compaction completed successfully"),
+                    Ok(true) => println!("Lore table compaction completed successfully"),
+                    Ok(false) => {}
                     Err(e) => error!("Failed to compact lore tables: {}", e),
                 }
 
@@ -1386,7 +1389,8 @@ async fn main() -> Result<()> {
                     Err(e) => eprintln!("Warning: Failed to ensure FTS indices: {}", e),
                 }
                 match db_manager.optimize_lore_fts_indices().await {
-                    Ok(_) => println!("FTS indices updated successfully"),
+                    Ok(true) => println!("FTS indices updated successfully"),
+                    Ok(false) => {}
                     Err(e) => eprintln!("Warning: Failed to optimize FTS indices: {}", e),
                 }
             }

src/database/connection.rs

@@ -889,7 +889,8 @@ impl DatabaseManager {
         self.schema_manager.compact_and_cleanup().await
     }
 
-    pub async fn compact_lore_tables(&self) -> Result<()> {
+    /// Returns false, after printing the problem, if any table failed.
+    pub async fn compact_lore_tables(&self) -> Result<bool> {
         self.schema_manager.compact_lore_tables().await
     }
 
@@ -909,7 +910,8 @@ impl DatabaseManager {
     }
 
     /// Merge newly-inserted rows into existing lore FTS indices.
-    pub async fn optimize_lore_fts_indices(&self) -> Result<()> {
+    /// Returns false, after printing why, if the merge was skipped.
+    pub async fn optimize_lore_fts_indices(&self) -> Result<bool> {
         self.schema_manager.optimize_lore_fts_indices().await
     }