Repository navigation
Conversation
`semcode-index -d db/foo` fails with "cannot connect to LanceDb Cloud unless the 'remote' feature is enabled". Any relative database path whose first component starts with "db" fails to open the same way, `dbdata/x` included. lancedb 0.27 sends every URI that starts with "db" to its cloud client, though only "db://" is meant for it. `DatabaseManager::new()` now passes the path to lancedb through `local_uri()`, which prefixes "./" to a path that starts with "db" but not "db://". That names the same directory in a string that does not start with "db". Every other path passes unchanged, and "db://" behaves as before. `local_uri()` can go once semcode's lancedb dependency checks for "db://". `tests/relative_db_path.rs` fails on main with the cloud error above and passes with this change. It opens a database by its relative path under a "db"-prefixed directory in the working directory, and creates the tables. Unit tests over a table of paths cover `local_uri()` itself.
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semcode-index -d db/foofails with "cannot connect to LanceDb Cloud unless the 'remote' feature is enabled". Any relative database path whose first component starts with "db" fails to open the same way,dbdata/xincluded. lancedb 0.27 sends every URI that starts with "db" to its cloud client, though only "db://" is meant for it.DatabaseManager::new()now passes the path to lancedb throughlocal_uri(), which prefixes "./" to a path that starts with "db" but not "db://". That names the same directory in a string that does not start with "db". Every other path passes unchanged, and "db://" behaves as before.local_uri()can go once semcode's lancedb dependency checks for "db://".tests/relative_db_path.rsfails on main with the cloud error above and passes with this change. It opens a database by its relative path under a "db"-prefixed directory in the working directory, and creates the tables. Unit tests over a table of paths coverlocal_uri()itself.