Skip to content

[INTT-48] Add git-cliff config and fast-forward workflow#17

Open
mzaniolo wants to merge 2 commits into
tlater/incrementalfrom
mzaniolo/git-cliff
Open

[INTT-48] Add git-cliff config and fast-forward workflow#17
mzaniolo wants to merge 2 commits into
tlater/incrementalfrom
mzaniolo/git-cliff

Conversation

@mzaniolo

@mzaniolo mzaniolo commented Jun 3, 2026

Copy link
Copy Markdown

No description provided.

Comment thread nix/general/ff-merge_workflow.nix Outdated
Comment thread nix/general/ff-merge_workflow.nix Outdated
Comment thread nix/general/ff-merge_workflow.nix
Comment thread nix/general/git-cliff.nix Outdated

["sequoia-pgp/fast-forward"]
rev = "v1.0.0"
ref = "ea7628bedcb0b0b96e94383ada458d812fca4979"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you double check this ref is currently permitted?

Comment thread nix/general/git-cliff.nix
@tlater-famedly tlater-famedly changed the title Add git-cliff config and fast-forward workflow [INTT-5] Add git-cliff config and fast-forward workflow Jun 10, 2026
@tlater-famedly tlater-famedly changed the title [INTT-5] Add git-cliff config and fast-forward workflow [INTT-48] Add git-cliff config and fast-forward workflow Jun 10, 2026
@mzaniolo mzaniolo force-pushed the mzaniolo/git-cliff branch from 9f77656 to 543188c Compare June 15, 2026 12:05
@mzaniolo mzaniolo requested a review from tlater-famedly June 15, 2026 12:16

@tlater-famedly tlater-famedly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if we could make cliff.toml slightly more readable by rewriting it in nix, since nix is much better than toml at multiline strings and unescaped template literals, but that's a minor thing we can change in the future.

in
{
perSystem =
{ ... }:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
{ ... }:

Comment thread nix/general/git-cliff.nix
@@ -0,0 +1,14 @@
importingFlake: {
perSystem =
{ ... }:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
{ ... }:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants