Skip to content

Syk/coverage - #104

Merged
itsoyou merged 2 commits into
mainfrom
syk/coverage
Sep 9, 2026
Merged

Syk/coverage#104
itsoyou merged 2 commits into
mainfrom
syk/coverage

Conversation

@itsoyou

@itsoyou itsoyou commented Sep 7, 2026

Copy link
Copy Markdown
Member

@itsoyou
itsoyou requested a review from a team as a code owner September 7, 2026 14:24
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.58%. Comparing base (d65ef91) to head (97784a2).

Files with missing lines Patch % Lines
synapse_token_authenticator/claims_validator.py 75.00% 2 Missing ⚠️
synapse_token_authenticator/config/epa.py 93.33% 0 Missing and 2 partials ⚠️
synapse_token_authenticator/config/oauth.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   77.26%   84.58%   +7.32%     
==========================================
  Files          13       13              
  Lines         884      902      +18     
  Branches      160      163       +3     
==========================================
+ Hits          683      763      +80     
+ Misses        126       85      -41     
+ Partials       75       54      -21     
Files with missing lines Coverage Δ
synapse_token_authenticator/token_authenticator.py 71.42% <ø> (+2.38%) ⬆️
synapse_token_authenticator/config/oauth.py 92.10% <94.44%> (+10.28%) ⬆️
synapse_token_authenticator/claims_validator.py 93.39% <75.00%> (+12.39%) ⬆️
synapse_token_authenticator/config/epa.py 89.47% <93.33%> (+17.05%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65ef91...97784a2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread synapse_token_authenticator/config/epa.py Outdated
Comment thread tests/test_config/test_epa.py Outdated
Comment thread synapse_token_authenticator/token_authenticator.py Outdated

@FrenchGithubUser FrenchGithubUser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, always nice to get more coverage!

@itsoyou
itsoyou added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 6169924 Sep 9, 2026
6 checks passed
@itsoyou
itsoyou deleted the syk/coverage branch September 9, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants