Skip to content

feat: drop config option user-id-path - #105

Merged
itsoyou merged 1 commit into
mainfrom
syk/remove-oauth-user-id-path
Sep 11, 2026
Merged

feat: drop config option user-id-path#105
itsoyou merged 1 commit into
mainfrom
syk/remove-oauth-user-id-path

Conversation

@itsoyou

@itsoyou itsoyou commented Sep 10, 2026

Copy link
Copy Markdown
Member

SYN-127

This is not a breaking change because now we "ignore" extra fields in the config.

@itsoyou
itsoyou requested a review from a team as a code owner September 10, 2026 14:03
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.55%. Comparing base (31474b4) to head (e290beb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   84.58%   84.55%   -0.04%     
==========================================
  Files          13       13              
  Lines         902      900       -2     
  Branches      163      163              
==========================================
- Hits          763      761       -2     
  Misses         85       85              
  Partials       54       54              
Files with missing lines Coverage Δ
synapse_token_authenticator/config/oauth.py 91.96% <ø> (-0.15%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31474b4...e290beb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread README.md Outdated
@itsoyou
itsoyou force-pushed the syk/remove-oauth-user-id-path branch from fc95ff5 to e290beb Compare September 11, 2026 09:40

@FrenchGithubUser FrenchGithubUser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@itsoyou
itsoyou added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 7d40c7d Sep 11, 2026
6 checks passed
@itsoyou
itsoyou deleted the syk/remove-oauth-user-id-path branch September 11, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants