Skip to content

fix: keep search dialog above page actions - #500

Merged
Kinfe123 merged 1 commit into
mainfrom
fix/search-dialog-layering
Sep 10, 2026
Merged

fix: keep search dialog above page actions#500
Kinfe123 merged 1 commit into
mainfrom
fix/search-dialog-layering

Conversation

@Kinfe123

@Kinfe123 Kinfe123 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary

  • move the command search overlay and dialog onto the framework modal layer
  • keep React/Farm, Astro, Nuxt, and Svelte theme styles aligned
  • add a cross-adapter regression test for search dialog layering

Verification

  • pnpm --filter @farming-labs/theme test -- omni-layering.test.ts (215 tests)
  • pnpm --filter @farming-labs/docs build
  • pnpm --filter @farming-labs/theme typecheck
  • pnpm --filter @farming-labs/theme build
  • browser verification with the command palette open; overlay 9998, dialog 9999, no console errors

Summary by cubic

Raises the command search dialog's z-index so it no longer renders below elevated page actions across all framework adapters.

  • Updates the overlay and dialog z-index from 50/51 to 9998/9999 in the Astro, Nuxt, Svelte, and React/Farm theme styles.
  • Adds a cross-adapter regression test that verifies the omni.css files keep these z-index values aligned.

Written for commit 1cc7186. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs-website Ready Ready Preview Sep 10, 2026 12:57am UTC
farming-labs-docs-docs-cloud Building Building Preview Sep 10, 2026 12:57am UTC

Request Review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@farming-labs/astro

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro@500

@farming-labs/astro-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro-theme@500

@farming-labs/docs

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/docs@500

@farming-labs/farmjs

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/farmjs@500

@farming-labs/theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/theme@500

@farming-labs/next

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/next@500

@farming-labs/nuxt

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt@500

@farming-labs/nuxt-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt-theme@500

@farming-labs/svelte

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte@500

@farming-labs/svelte-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte-theme@500

@farming-labs/tanstack-start

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/tanstack-start@500

commit: 1cc7186

@Kinfe123
Kinfe123 merged commit a4624b0 into main Sep 10, 2026
21 of 23 checks passed
@Kinfe123
Kinfe123 deleted the fix/search-dialog-layering branch September 10, 2026 00:54
@Kinfe123 Kinfe123 mentioned this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant