fix: allow autoConfig callbacks without global options - #529
Open
lprnmns wants to merge 1 commit into
Open
Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
lprnmns
marked this pull request as ready for review
August 31, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an autoloaded plugin exports a function-valued
autoConfigand the autoload call omits the optional globaloptionsobject, registration throwsTypeError: Cannot read properties of undefined (reading 'prefix'). The documented callback configuration therefore cannot load unless callers provide an otherwise unnecessary empty options object.Fix
Default the internal override configuration to an empty object before the callback result is merged. Explicit global options and the existing prefix precedence remain unchanged.
Tests
node --test --test-name-pattern='loads a plugin when the global options object is omitted' test/commonjs/auto-config-no-global.js— failed before the fix with the expected TypeError; passed after the fixnpm test— passed; borp reported 275 passed, 0 failed, and 100% coveragenpm run lint— passednode --check index.js && node --check test/commonjs/auto-config-no-global.js && node --check test/commonjs/auto-config-no-global/route.js— passedgit diff --check HEAD^ HEAD— passedCompatibility
This changes only the previously failing callback-only configuration. Calls that provide global options retain their existing merge and prefix behavior; no public type, dependency, or package-version change is included.
Related issue
Independent reproduction; no linked issue. Function-valued
autoConfigsupport was previously introduced by historical PR #381.