statsmanager: add rust type and ffi for managing common metrics - #48425
Merged
Conversation
clintjedwards
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
statsmanagerRust module along with aCommonMetricstype and FFI for managing the kinds of metrics that the C++StatsManagerclass would need if it were to rely on Rust code for managing its Prometheus metrics.For now this code is unused, but the plan is to change
StatsManagerto callCommonMetrics::updatewith the values from itscombinedReportfield. The values incombinedReportare cumulative, soupdatecomputes deltas to increment by.Note: normally, we should declare Prometheus metrics within the specific components that use them rather than in core (e.g. connmgr's metrics are declared in the
connmgrmodule), however sinceStatsManageris already in core it is easier to start out by putting the metrics it needs alongside it, hence naming them "common" metrics. Later on we can consider teasing them out somehow into separate components.