statsmanager: allow multiple instances to share a prometheus server - #48431
Merged
Conversation
clintjedwards
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a few things:
PrometheusServerandCommonMetricsconstructions are moved outside ofStatsManager.shared_ptr<CommonMetrics>is passed to eachStatsManagerinstance. Notably,StatsManagerno longer needs awareness ofPrometheusServer.StatsManagerinstance registers with the suppliedCommonMetricsinstance, and then identifies itself when callingCommonMetrics::update. This is needed to allow per-instance bookkeeping of "previous" values.The
connection_connectedgauge is maintained as an aggregate by applying potentially negative deltas and by subtracting on unregistration.Tested locally, by setting proxy
workers=2, confirming different workers performing work, and then confirming the single prometheus server returning aggregate results.