Repository navigation
Conversation
Member
|
Thanks for reporting and for the fix! The test failure seems to be non-related (I'm rerunning to check) and the style failure as well. I'll take a closer look later and merge if nothing comes up. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting a bunch of
ResourceWarnings in MNE-Python CIs:Fix it by wrapping in context managers that close the resource.
The diff is really just a couple of lines plus an indentation change, so viewing with whitespace off might aid review.
This is really arguably an upstream bug with
urllib3-futurewhere a session can be closed too early, but by creating and using thesession,poochcan avoid it.Relevant issues/PRs:
None that I saw with a quick search