Skip to content

Set dims to longitude, latitude if projection passed#328

Open
santisoler wants to merge 7 commits into
2.0-devfrom
dims-on-projection
Open

Set dims to longitude, latitude if projection passed#328
santisoler wants to merge 7 commits into
2.0-devfrom
dims-on-projection

Conversation

@santisoler

Copy link
Copy Markdown
Member

Make BaseGridder.grid, BaseGridder.scatter and BaseGridder.profile to use
("latitude", "longitude") as default dims if a projection is passed.

After fatiando/harmonica#233

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

@santisoler
santisoler requested a review from leouieda July 19, 2021 13:32
@santisoler

Copy link
Copy Markdown
Member Author

We're breaking some backward compatibility by returning new set of coord in the generated outputs, that's why I had to change some tests. Is it OK or should we leave this PR for 2.0.0?

@leouieda leouieda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, probably best to wait for 2.0. We should start a branch to gather these PRs.

Comment thread verde/base/base_classes.py Outdated
@santisoler
santisoler requested a review from leouieda August 30, 2021 16:23
@santisoler santisoler added this to the v2.0.0 milestone Aug 31, 2021
@leouieda
leouieda changed the base branch from master to 2.0-dev November 3, 2021 10:49
Comment thread verde/base/base_classes.py Outdated
@leouieda

leouieda commented Nov 3, 2021

Copy link
Copy Markdown
Member

I've changed the base here to 2.0-dev so once the merge conflict is resolved we can merge this.

santisoler and others added 3 commits November 3, 2021 13:02
Co-authored-by: Leonardo Uieda <leouieda@gmail.com>
Add one more test where projection argument is omitted.
@leouieda
leouieda deleted the branch 2.0-dev November 29, 2024 13:21
@leouieda leouieda closed this Nov 29, 2024
@leouieda leouieda reopened this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants