Error-erasing StorageSequence and demand test - #12
Merged
Merged
Conversation
Replace the AsyncStream<Result<ByteBuffer, any Error>> wrapper with a small ErrorErasingSequence that erases the failure type, simplifying StorageSequence internals and iterator typing (uses any AsyncIteratorProtocol/any AsyncSequence). This removes the Result wrapping and stream machinery while preserving behavior. Add a unit test (DemandProbe + DemandTrackingSequence) that verifies StorageSequence only requests upstream elements when the consumer advances (demand-driven).
StorageSequence was retaining a single base async sequence, which could reuse iterator state across calls. This change creates a fresh iterator per makeAsyncIterator invocation while preserving the existing error-erased sequence behavior.
tib
approved these changes
Sep 16, 2026
This change renames the internal StorageSequence wrapper from ErrorErasingSequence to FailureErasingAsyncSequence to better reflect its purpose. The sequence still erases failure types while preserving byte-buffer output, keeping the StorageSequence API behavior unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the AsyncStream<Result<ByteBuffer, any Error>> wrapper with a small ErrorErasingSequence that erases the failure type, simplifying StorageSequence internals and iterator typing (uses any AsyncIteratorProtocol/any AsyncSequence). This removes the Result wrapping and stream machinery while preserving behavior. Add a unit test (DemandProbe + DemandTrackingSequence) that verifies StorageSequence only requests upstream elements when the consumer advances (demand-driven).