Skip to content

FDG-11892 Migrate 'U.S. Deficit Compared to Revenue/Spending' Chart from Nivo to Recharts - #2323

Merged
chasls2 merged 4 commits into
masterfrom
FDG-11892
Aug 25, 2026
Merged

FDG-11892 Migrate 'U.S. Deficit Compared to Revenue/Spending' Chart from Nivo to Recharts#2323
chasls2 merged 4 commits into
masterfrom
FDG-11892

Conversation

@LaKeishaW

@LaKeishaW LaKeishaW commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:

FDG-11892

The following are ALL required for the PR to be merged:

  • Provided testing instructions in JIRA ticket if applicable
  • Provided mocks or additional information in JIRA ticket if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome)
  • Verify all files are covered by at least 93% test coverage if applicable
  • Verify that dashes are used for any visible defaults of evergreen values if applicable
  • Check for code quality
    + Watch out for irrelevant changes
    + Take time to understand the logic and flow; be on guard for pitfalls
    + Look at handoff between components (esp. number of props)
    + Watch out for literals (vs. variables) for css specs if applicable

@LaKeishaW
LaKeishaW marked this pull request as draft August 21, 2026 19:52
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Total Line Coverage: 93.26% ✅

@ntsim99 ntsim99 self-assigned this Aug 25, 2026
@ntsim99
ntsim99 marked this pull request as ready for review August 25, 2026 02:51

@chasls2 chasls2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The greater the measure, the greater the chart. Approved

@chasls2
chasls2 merged commit b76fece into master Aug 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants