Skip to content

Support icons#273

Open
Param3005 wants to merge 2 commits into
fencer-so:mainfrom
Param3005:main
Open

Support icons#273
Param3005 wants to merge 2 commits into
fencer-so:mainfrom
Param3005:main

Conversation

@Param3005

Copy link
Copy Markdown

Summary

This pull request adds support for goal icons across the CommBank application.

Changes made

  • Added an optional icon field to the Goal model.
  • Updated the frontend Goal type to support icons.
  • Displayed goal icons on goal cards.
  • Implemented an emoji picker using emoji-mart to allow users to select and change goal icons.
  • Updated the Goal Manager to save icon changes locally and through the backend.
  • Added support for updating goals with a PUT request.
  • Added tests for the GetGoalsForUser endpoint.

Testing

  • Verified the API using Postman.
  • Confirmed that goal icons are returned by the API.
  • Verified that icon updates persist after refreshing the client.

@gitguardian

gitguardian Bot commented Jul 2, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials bdc3278 CommBank-Server/Secrets.json View secret
- - MongoDB Credentials 89f5311 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Param3005 Param3005 closed this Jul 2, 2026
@Param3005 Param3005 reopened this Jul 2, 2026
@Param3005
Param3005 marked this pull request as draft July 2, 2026 19:58
@Param3005
Param3005 marked this pull request as ready for review July 2, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant