Skip to content

test completed#295

Open
NAV2003een wants to merge 3 commits into
fencer-so:mainfrom
NAV2003een:tests
Open

test completed#295
NAV2003een wants to merge 3 commits into
fencer-so:mainfrom
NAV2003een:tests

Conversation

@NAV2003een

Copy link
Copy Markdown

Adds unit test coverage for the GetForUser route on GoalController.

  • Follows the same Arrange/Act/Assert pattern as the existing Get/GetAll tests
  • Uses FakeGoalsService/FakeUsersService for isolation
  • Asserts the result is non-null and each returned Goal has the expected UserId

@gitguardian

gitguardian Bot commented Jul 16, 2026

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@NAV2003een
NAV2003een force-pushed the tests branch 2 times, most recently from 9118cc9 to b598d17 Compare July 16, 2026 12:01
@NAV2003een

Copy link
Copy Markdown
Author

Adds unit test coverage for the GetForUser route on GoalController.

  • Follows the same Arrange/Act/Assert pattern as the existing Get/GetAll tests
  • Uses FakeGoalsService/FakeUsersService for isolation
  • Asserts the result is non-null and each returned Goal has the expected UserId

@NAV2003een
NAV2003een marked this pull request as draft July 16, 2026 12:25
@NAV2003een
NAV2003een marked this pull request as ready for review July 16, 2026 12:25
@NAV2003een NAV2003een closed this Jul 16, 2026
@NAV2003een

Copy link
Copy Markdown
Author

Note: an earlier commit in this branch briefly included a real database
connection string in Secrets.json. This was removed via a follow-up commit,
and the credential has been rotated. The current code contains no secrets.

@NAV2003een
NAV2003een deleted the tests branch July 16, 2026 12:50
@NAV2003een
NAV2003een restored the tests branch July 16, 2026 12:51
@NAV2003een NAV2003een reopened this Jul 16, 2026
@NAV2003een

Copy link
Copy Markdown
Author

Note: an earlier commit in this branch briefly included a real database
connection string in Secrets.json. This was removed via a follow-up commit,
and the credential has been rotated. The current code contains no secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant