Skip to content

Support icons#299

Open
Santoshray-27 wants to merge 2 commits into
fencer-so:mainfrom
Santoshray-27:icons
Open

Support icons#299
Santoshray-27 wants to merge 2 commits into
fencer-so:mainfrom
Santoshray-27:icons

Conversation

@Santoshray-27

Copy link
Copy Markdown

Summary

This pull request adds support for goal icons using an emoji picker and persists the selected icon to the backend.

Changes made

  • Added an optional icon field to the Goal model
  • Displayed goal icons on the goal cards
  • Implemented a reusable Emoji Picker component using emoji-mart@3.0.1
  • Updated the Goal Manager to allow users to add and change icons
  • Added a PUT request in lib.ts to update goals
  • Updated Redux state after selecting an emoji
  • Persisted emoji changes so they remain after refreshing the page

Testing

  • Verified the application builds and runs successfully
  • Verified goal cards display emoji icons
  • Verified the emoji picker opens when selecting or adding an icon
  • Verified selecting an emoji updates the goal icon
  • Verified the icon persists after refreshing the client

@gitguardian

gitguardian Bot commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 12e4992 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant