Skip to content

Support icons#24

Open
Aayush9-spec wants to merge 1 commit into
fencer-so:masterfrom
Aayush9-spec:icons
Open

Support icons#24
Aayush9-spec wants to merge 1 commit into
fencer-so:masterfrom
Aayush9-spec:icons

Conversation

@Aayush9-spec

Copy link
Copy Markdown

This PR merges the implementation of custom icons for goals.

What was done:

  • C# Backend: Added an optional public Icon field of type string to the Goal model and updated the corresponding endpoints to persist changes.
  • React/TypeScript Frontend: Integrated emoji-mart for the emoji selector, updated the GoalCard to display the selected icon, and modified GoalManager to handle selecting/changing icons.
  • Networking: Connected the client-server interaction by implementing and calling the updateGoal PUT request on the frontend.
  • Testing: Covered the new backend routes with unit tests using xUnit.

@gitguardian

gitguardian Bot commented Jul 10, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 7eb7120 commbank-server/CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant