Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS event-tap callback can wait for the shared capture-state mutex or a full event queue. If capture is disabled, its notification can also be lost on a full control channel, leaving the stream pending and the frontend unaware. We observed repeated physical edge-entry failures and one
capture-state lock deadline exceededafter returning from a peer.This draft is stacked on #473 (
3d20297) and retains its physical/emulated input routing. Please review the follow-up commit separately; the PR diff includes #473 until that dependency is merged.The follow-up:
EventTapDisabled. The existing capture task/IPC/frontend then publishes Disabled and supports explicit Reenable.No external supervisor, SSH connection, protocol change or new production dependency is required for these failure paths. This is not a replacement for out-of-process recovery from an arbitrary whole-process hang: synchronous CoreGraphics calls are still unbounded.
Validation on Apple Silicon, macOS 27.2:
-D warnings, formatting and whitespace checks pass.The observed 2ms lock failure is established. We did not capture the fault-time lock-owner stack, so the previous specific slow CoreGraphics call is not claimed as a proven trigger. New instrumentation records cursor visibility calls exceeding 2ms without logging input contents.