Skip to content

chore(deps): update async-trait to 0.1.92 (fixes clippy with Rust 1.99) - #531

Open
ekremyk2 wants to merge 1 commit into
feschber:mainfrom
ekremyk2:fix-clippy-async-trait
Open

ekremyk2 wants to merge 1 commit into
feschber:mainfrom
ekremyk2:fix-clippy-async-trait

Conversation

@ekremyk2

Copy link
Copy Markdown

Clippy 1.99 added the double_must_use lint. It fires on the #[must_use] that async-trait 0.1.89 puts on the methods it generates, so clippy --workspace --all-targets --all-features -- -D warnings now fails on the #[async_trait] traits in input-capture and input-emulation. CI on main will hit this as soon as its runners pick up Rust 1.99. It already does on ubuntu-latest.

async-trait 0.1.92 no longer triggers the lint. This PR only updates the lockfile (cargo update -p async-trait). The new async-trait depends on syn 3, so that appears in Cargo.lock next to syn 2.

Tested with Rust 1.99 locally, where all clippy warnings are gone. The full CI matrix (formatting, plus build, check, test and clippy on Ubuntu, Windows, macOS and macOS Intel) passes on my fork: https://github.com/ekremyk2/lan-mouse/actions/runs/38411673978

This was made with the help of AI (Claude by Anthropic).

Clippy 1.99 flags the `#[must_use]` that older async-trait versions put
on the generated methods (`double_must_use`), which fails CI because
clippy runs with `-D warnings`. With async-trait 0.1.92 the warning is
gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant