Skip to content

fix(gov): parse expedited proposal responses #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisWozniak wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −2
Open

fix(gov): parse expedited proposal responses #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cosmpy/gov/rest_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ def Proposal(self, request: QueryProposalRequest) -> QueryProposalResponse:
json_response = self._rest_api.get(
f"{self.API_URL}/proposals/{request.proposal_id}",
)
return Parse(json_response, QueryProposalResponse())
return Parse(
json_response,
QueryProposalResponse(),
ignore_unknown_fields=True,
)

def Proposals(self, request: QueryProposalsRequest) -> QueryProposalsResponse:
"""
Expand All @@ -80,7 +84,11 @@ def Proposals(self, request: QueryProposalsRequest) -> QueryProposalsResponse:
f"{self.API_URL}/proposals/",
request,
)
return Parse(json_response, QueryProposalsResponse())
return Parse(
json_response,
QueryProposalsResponse(),
ignore_unknown_fields=True,
)

def Vote(self, request: QueryVoteRequest) -> QueryVoteResponse:
"""
Expand Down
32 changes: 32 additions & 0 deletions tests/unit/test_gov/test_rest_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,21 @@ def test_Proposal(self):
assert gov.Proposal(QueryProposalRequest(proposal_id=1)) == expected_response
assert mock_client.last_base_url == "/cosmos/gov/v1beta1/proposals/1"

def test_Proposal_with_is_expedited(self):
"""Test Proposal handles expedited proposal responses."""
content = {
"proposal": {
"proposal_id": "543",
"is_expedited": True,
}
}
mock_client, gov = self.make_clients(content)

response = gov.Proposal(QueryProposalRequest(proposal_id=543))

assert response.proposal.proposal_id == 543
assert mock_client.last_base_url == "/cosmos/gov/v1beta1/proposals/543"

def test_Proposals(self):
"""Test Proposals method."""
content = {
Expand Down Expand Up @@ -117,6 +132,23 @@ def test_Proposals(self):
assert gov.Proposals(QueryProposalsRequest()) == expected_response
assert mock_client.last_base_url == "/cosmos/gov/v1beta1/proposals/"

def test_Proposals_with_is_expedited(self):
"""Test Proposals handles expedited proposal responses."""
content = {
"proposals": [
{
"proposal_id": "543",
"is_expedited": True,
}
]
}
mock_client, gov = self.make_clients(content)

response = gov.Proposals(QueryProposalsRequest())

assert response.proposals[0].proposal_id == 543
assert mock_client.last_base_url == "/cosmos/gov/v1beta1/proposals/"

def test_Vote(self):
"""Test Vote method."""
content = {"vote": {"proposal_id": "10", "voter": "addr"}}
Expand Down