Fix Pod::Spell by loading Encode for encoding layers#869
Open
fglock wants to merge 1 commit into
Open
Conversation
Match Perl's visible side effect of loading Encode when an :encoding(...) layer is applied. Pod::Spell relies on this after its wordlist is opened as UTF-8. Add a focused regression test for Encode::encode availability. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode.pmwhen applying a PerlIO:encoding(...)layerPerlIO::encodingEncode::encodeavailabilityRoot cause
Pod::Wordlistopens its bundled wordlist with:encoding(UTF-8).Standard Perl loads
Encodewhile applying that layer, andPod::Spelllater calls
Encode::encode. PerlOnJava performed the charset conversiondirectly without loading
Encode, so the call was undefined.Test plan
prove src/test/resources/unit/perlio_encoding_loads_encode.t./jperl src/test/resources/unit/perlio_encoding_loads_encode.t./jcpan Pod::Spell— all 8 test files and 54 tests pass; install succeedsmake— compilation and 223 unit tests passed, then the unrelated existingunit/refcount/weaken_edge_cases.ttest 37 failed; the same failure reproduceswhen that test is run standalone
Generated with Codex