Chris' suggestions#1
Open
caalo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCGA_analysis Updated June2026.R!source("TCGA_analysis Function 2026.R")clinical,expression, anddata_sethat were originally defined in the main code (TCGA_analysis Updated June2026.R) are used in the functions. This is generally not best coding practice as it make the functions not modular (and in other coding languages, these variables are at the risk of being modified within the function), as the function depends on having these variables defined in the first place. What is usually done is that these variables are passed into the function as inputs also, to make the function self-contained. I have modified the functions to take in two new variablessummarized_experimentandnormalized_expression, andclinicalandrow_infoare derived fromsummarized_experimentwithin the function. So when we call the function, we have to give these new inputs as well!compositeSurvivalAnalysis(). Even though we are not iterating through genes, it's nice to be able to call the code with a function so you don't have to manually run it.