Skip to content

deps: bump zip to 9.0.3 (all of 8.x is yanked) - #194

Open
sanghnkim-max wants to merge 1 commit into
firecrawl:mainfrom
sanghnkim-max:zip-9
Open

sanghnkim-max wants to merge 1 commit into
firecrawl:mainfrom
sanghnkim-max:zip-9

Conversation

@sanghnkim-max

@sanghnkim-max sanghnkim-max commented Oct 16, 2026 •

Copy link
Copy Markdown

zip-rs has yanked every 8.x release, plus 9.0.0–9.0.2. zip = "8.6.0" therefore resolves only to yanked versions, and downstream crates fail cargo deny (error[yanked]) with no way to fix it from their side. The releases after 8.6.0 fix symlink-following during extraction, overflows in the implode decoder, and reads past an entry's declared size.

This changes Cargo.toml and fuzz/Cargo.toml to 9.0.3 and updates the lockfile. No code changes: anydoc only uses ZipWriter, SimpleFileOptions, ZipArchive::new/by_name and ZipError::FileNotFound, and none of those changed in 9. zip 9.0.3 keeps rust-version = 1.88.

cargo test --workspace (296 passed), cargo clippy --all-targets -- -D warnings and cargo fmt --check are all clean. A release on this would let us drop our vendored copy.

🤖 Generated with Claude Code


Summary by cubic

Bumps zip from 8.6.0 to 9.0.3 so downstream crates can pass cargo deny: all 8.x releases, plus 9.0.0–9.0.2, are yanked, leaving ^8.6.0 resolving only to yanked versions.

No code changes are needed — the used APIs (ZipWriter, SimpleFileOptions, ZipArchive::by_name) are unchanged in 9, and rust-version stays at 1.88. The bump also picks up fixes for symlink-following during extraction, decoder overflows, and reads past an entry's declared size.

Written for commit 3b829c6. Summary will update on new commits.

View guided diff

zip-rs yanked every 8.x release (and 9.0.0-9.0.2), so a crate requiring
^8.6.0 resolves only to yanked versions and fails cargo-deny downstream.
The releases since 8.6.0 fix symlink-following during extraction, decoder
overflows and reads past an entry's declared size. Only ZipWriter and
ZipArchive::by_name are used here, both unchanged in 9; tests pass as is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

View guided diff | Re-trigger cubic

@tidusvn05

Copy link
Copy Markdown

Confirming this fixes things downstream. Every zip 8.x release is yanked, so projects that depend on anydoc now fail cargo deny / yanked-crate checks. For us that is okbot, through okbase-convert.

Checked on this branch (3b829c6):

  • cargo test --locked passes (286 + 9 + 1 tests).
  • With anydoc patched to this branch, okbot's knowledge crate builds and its tests pass on zip 9.0.3.
  • zip 9.0.3 declares rust-version = 1.88, the same MSRV the Cargo.toml comment mentions.

A 0.2.5 release with this change would be much appreciated. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants