Skip to content

fix: better support for serial suites - #87

Merged
aslushnikov merged 4 commits into
mainfrom
distinguish-between-skipped-and-not-run
Oct 17, 2026
Merged

aslushnikov merged 4 commits into
mainfrom
distinguish-between-skipped-and-not-run

Conversation

@aslushnikov

@aslushnikov aslushnikov commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Playwright differentiates 2 types of skipped tests:

  • "explicit": these are skipped via the API's test.skip() call
  • "implicit": these are skipped for some other reason. For example, or it can be skipped due to an early failure in a .serial test suite.

This patch learns to distinguish between these states. The "implicit" skips are not reported.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T22:26:53.424142Z ccccc0c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d37db16828

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/reportBuilder.ts Outdated
@aslushnikov aslushnikov changed the title fix: distinguish between skipped and not run tests fix: better support for serial suites Oct 16, 2026
@flakiness-io

flakiness-io Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
ccccc0c ✅ Passed 233 passed · 1 skipped 3 runs

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

@aslushnikov
aslushnikov merged commit a434a05 into main Oct 17, 2026
7 checks passed
@aslushnikov
aslushnikov deleted the distinguish-between-skipped-and-not-run branch October 17, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant