fix(tests): rewire u.process consumers to the fail-loud PR #504 contract - #204
Merged
Merged
Conversation
flext-core PR #504 (merged 8de52fa6b) removed the on_error parameter from u.process: the first processor failure now returns r.fail carrying the original exception, and there is no skip/collect mode. Drop the removed on_error="fail" kwarg from the success-path test, delete the skip-policy test (that behaviour no longer exists), and add a behavioural replacement through the public u facade asserting the run stops at the first failure and result.exception is the processor's original exception. Also regenerate managed projections (pyproject.toml, uv.lock, docs, Makefile) via make upg/gen so the lock pins flext-core at 8de52fa6b. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
8de52fa6b) removed theon_errorparameter fromu.process(FlextUtilitiesCollection.process). The first processor failure now returnsr.failcarrying the processor's originalexception, with no skip/collect mode.tests/unit/test_utilities_cov.py:37dropped the removedon_error="fail"kwarg (no behavior change —"fail"was already the only real mode).tests/unit/test_utilities_cov.py:43(theon_error="skip"test) is deleted — that behaviour no longer exists.test_process_fails_loud_with_original_exception_and_stops_at_first_failure, a behavioural test through the publicufacade proving the run stops at the first failing item (later items are never visited) andresult.exceptionis the processor's original raised exception.src/flext_cli/_utilities/validation.pyandtests/unit/test_cmd_runtime_validation_branch_cov.pywere checked for leftoverprocess_mappingmodes from flext-cli PR fix(cli): fail loud at the remaining CLI_SAFE_EXCEPTIONS sites; timing-free process tests #203 — none found; that cleanup already landed on the tip.make upgre-resolved the lock, pinningflext-coreto8de52fa6b(the exact PR #504 merge commit);make genregenerated the managed projections that follow from that lock bump (docs, Makefile, pyproject.toml, mkdocs.yml, a couple of generated catalog files).Evidence (worktree
/home/marlonsc/flext-work/v8-process-consumers/flext-cli)make upg: exit 0 — lock pinsflext-core @ git+...@0.12.0-dev#8de52fa6b117ef54a840ac655c4518aff26ba027.make setup: exit 0.make genx2: exit 0 both times; identical working-tree diff after the second run (fixed point).make fix: exit 0, 0 errors.make fmt: exit 0, 1 file reformatted (unrelated cosmetic reflow intests/unit/test_runtime_process_descendants.py).make check: exit 0,Total: 1 Success: 1 Failed: 0 Skipped: 0, 15 gates at 0 errors (duplication/codemod/boundary/namespace/runtime-census gates suspended by operator authority flext-itpd1.3).make test: exit 0,1193 passed— includestest_process_fails_when_processor_raises,test_process_fails_loud_with_original_exception_and_stops_at_first_failure,test_process_predicate_excludes_items_before_processing, all passing.u.processcall through the installed flext-cli package (not just pytest):Test plan
make checkgreen (15 gates, 0 errors)make testgreen (1193 passed)u.processfail-loud contract through the flext-cli publicufacade🤖 Generated with Claude Code
Summary by cubic
Rewires
u.processtest consumers to the fail-loud contract from flext-core PR #504, which removed theon_errorparameter. The first processor failure now returnsr.failcarrying the processor's original exception, with no skip/collect mode.on_error="fail"kwarg — no behavior change, since"fail"was the only real mode.on_error="skip"test, as that mode no longer exists.result.exceptionis the processor's original exception.flext-coreinuv.lockto the PR #504 merge commit and regenerated the managed projections (docs, Makefile, pyproject.toml, mkdocs.yml).Written for commit 62b3156. Summary will update on new commits.