feat(files): csv_dumps mirrors csv_loads at the csv boundary - #206
Merged
Merged
Conversation
Consumers that render CSV (ArtifactPack binding) reached for the raw csv module because the boundary exposed only the parse side. csv_dumps serializes rows with LF terminators so csv_loads round-trips exactly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The csv boundary owned only the parse side; serialization consumers reached for the raw csv module.
u.Cli.csv_dumps(rows, delimiter=',')writes LF-terminated CSV socsv_loadsround-trips exactly. Evidence: lint clean; csv roundtrip proof; 5 csv tests green.Summary by cubic
Adds
csv_dumpsto the CSV boundary so serialization consumers no longer reach for the raw csv module. It writes LF-terminated rows socsv_loadsround-trips exactly.Written for commit a5ca632. Summary will update on new commits.