feat(protocols): p.Service is the truthful service surface (V8 S4) - #508
Merged
marlon-costa-dc merged 2 commits intoSep 26, 2026
Merged
Conversation
p.Service declared five members no FlextService implements (service_info, valid, validate_business_rules, ok, fail_op), so isinstance(real_service, p.Service) was False. It now inherits the runtime surface from MixinsInfrastructure (declared once: settings, container, context, logger, track, runtime seeds) and adds only execute; every real service satisfies it. The members that consume those capabilities already declare them in their own protocols (flext-web #106, flext-oracle-oic #112, flext-db-oracle #113). p.Executable, unused fleet-wide and carrying the same phantom service_info, is removed. The tautological isinstance-of-own-base test is replaced by the protocol contract and a negative case. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Slice S4 of plan V8 (bead flext-4jtcb.10), core step after the members (flext-web #106, flext-oracle-oic #112, flext-db-oracle #113 merged).
Runtime: isinstance(Echo(), p.Service) is True (was False).
Local pre-push gate GREEN: gen (clean tree), audit, check, test.
🤖 Generated with Claude Code
Summary by cubic
Makes
p.Servicematch the surface every real service implements, soisinstance(real_service, p.Service)is nowTrueinstead ofFalse.MixinsInfrastructureand adds onlyexecute, dropping five declared members that no service implements.p.Executableprotocol, which carried the same phantomservice_info.Written for commit e856965. Summary will update on new commits.