Repository navigation
fix(enforcement): CONFIG_FILENAMES is a framework ClassVar hook - #511
Merged
Merged
Conversation
FlextConfig declares CONFIG_FILENAMES and its loader reads it through cls, so a consumer override must stay on the config class; relocating it to _constants breaks the framework read. Exempt it like the other framework idioms.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENFORCE-079 flagged a consumer's CONFIG_FILENAMES ClassVar override, but the name is FlextConfig's own loader hook (read through
cls) — relocating it to _constants would break the framework read. Exempted alongside the other framework idioms in the SSOT set. Evidence: 31 classvar/exempt/placement tests green.Summary by cubic
Fixes ENFORCE-079 by exempting
CONFIG_FILENAMESfrom ClassVar relocation enforcement.FlextConfig declares
CONFIG_FILENAMESand its loader reads it throughcls, so a consumer override must stay on the config class; relocating it to_constantswould break the framework read.Written for commit f977352. Summary will update on new commits.