fix: stop the VSCode carousel overflowing to the right - #225
Merged
Conversation
The carousel is a direct child of a .row, and Bootstrap gives every direct row child `width: 100%` and `flex-shrink: 0`. Its `ms-4 me-4` therefore could not narrow it: margin-left simply pushed the full-width box 24px right and margin-right hung another 24px off the end. The slides ended up 36px past the right edge of the feature lists above them (24px past the container itself), while sitting 12px inside on the left; at phone widths the box overflowed the viewport. Drop the margins so the slides line up flush with the columns above and the tooling table below. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VSCode carousel on the front page hung off the right-hand side of the page.
Cause
The carousel is a direct child of a
.row, and Bootstrap gives every direct row childwidth: 100%andflex-shrink: 0. Itsms-4 me-4therefore could not narrow it — margin-left just pushed the already-full-width box 24px right, and margin-right hung another 24px off the end.Measurements
Taken on the rendered page at a 1400px viewport, where the feature lists above the carousel span
154 → 1246:So the slides were 36px past the right edge of the columns above them, and 24px past the container's own edge, while being inset 12px on the left. At 390px it was worse: the carousel box ended at 402 against a 390px viewport, overflowing the screen.
Dropping the margins leaves the slides flush with the feature lists above and the tooling table below, at 1400px and at 390px alike.
🤖 Generated with Claude Code