Add GitHub Actions CI workflow (build, vet, test) - #1
Merged
Merged
Conversation
RelayFee and EstimateFee discarded the cancel function returned by context.WithTimeout (flagged by go vet's lostcancel check). Deferring cancel releases the timer as soon as the function returns instead of leaking it until the 10s timeout fires on its own.
Runs on push to main and on pull requests: go build ./..., go vet ./..., go test ./.... Uses go-version-file so the toolchain always tracks go.mod instead of being hardcoded.
git-nostr
marked this pull request as ready for review
July 23, 2026 21:24
siblak
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/ci.yaml: runs on push tomainand on pull requests, executinggo build ./...,go vet ./..., andgo test ./.... Usesgo-version-file: go.modso the toolchain always tracks whatever this repo'sgo.moddeclares.Also fixes one real bug found while verifying this:
wallet/service.go'sRelayFeeandEstimateFeeboth discarded the cancel function fromcontext.WithTimeout(flagged bygo vet's lostcancel check), leaking the timer until the 10s timeout fired on its own instead of releasing it when the function returned.Part of a broader rollout adding CI to the org's Go repos that don't have any yet (mirroring what already shipped for go-flokicoin).
Test plan
go build ./...,go vet ./...,go test -count=1 ./...all pass cleanly (standalone module mode, matching how CI will run)