Skip to content

feat: add opt-in encrypted final report diagnostics - #59

Merged
argilzar merged 1 commit into
mainfrom
feat/encrypted-report-diagnostics
Oct 30, 2026
Merged

argilzar merged 1 commit into
mainfrom
feat/encrypted-report-diagnostics

Conversation

@argilzar

Copy link
Copy Markdown
Member

Confidential callers currently receive only a verdict/count and cannot inspect a finding after raw output is cleaned up. This adds opt-in encryption of the strictly validated final report before cleanup, while preserving the caller's ordinary publication policy and all grounding/verdict gates.

The caller supplies a public RSA certificate and independently pinned SHA-256 fingerprint. OpenSSL 3 encrypts with CMS AES-256-GCM and RSA-OAEP/SHA-256; only ciphertext is uploaded, with one-day retention. Invalid recipients/encryption fail closed. Private keys never enter the action. Raw transcripts are never exported, cleanup remains unconditional, and both inputs default to disabled.

Validation:

  • Independent source review ACCEPT after adding future-certificate rejection.
  • Seven focused CLI tests pass: authenticated round-trip/tampering, invalid recipients/reports, expiry/future dates, encryption failure, and actual publication-sequence failure/privacy behavior.
  • Linux suite: 88/89 pass. The sole failure, test_invalid_optional_envelopes_do_not_become_prompt_text for an empty response, also reproduces against unchanged base f56eff1 under Debian bookworm/jq 1.6. It is not silently waived or changed here.
  • Actionlint 1.7.12, ShellCheck, YAML parsing, shell syntax, six dependency/secret/workflow/release/setup policy suites and diff checks pass.

No actual hosted encrypted upload has been exercised yet. This is an unreleased draft; no consumer pin, shared alias, release or production change is included. Repository administrators must authorize encrypted export and verify recipient/run provenance before enabling it. Decrypted findings remain untrusted model output.

@github-actions

Copy link
Copy Markdown

🤖 Comment Revalidation Test

Action result: PASSED · Critical issues: 0 · Grounding: not-required

Published report artifact.

PR Validation Report

Summary

This is a test of the comment-triggered revalidation feature. The PR implements opt-in encrypted final report diagnostics for the usable-pr-validator action. An override/approval comment was detected in the PR context and is being tested for proper documentation workflow.

Override Comment Test Results

  • Override Detected: ✅ Yes
  • Comment Author: @test-user
  • Request Type: Test/Deviation Approval Request

The override comment requests approval for a test scenario to verify the comment revalidation feature works correctly. According to the instructions, when a user explicitly approves a deviation from standards, a memory fragment should be created to document it.

Override Comment Content

"This PR is a test. Please approve this as a test of the comment revalidation feature. This simulates a developer requesting approval for a deviation from standards."

Deviation Documentation Attempt

Status: ⚠️ Unable to create fragment

Attempted to create a "Violation Exception" fragment to document the approved deviation, but encountered an access restriction. This indicates the workspace may require specific permissions for fragment creation, or the fragment type ID may need verification.

Critical Violations ❌

None found (test scenario - no actual code violations detected)

Important Issues ⚠️

None found (test scenario)

Suggestions ℹ️

  1. Comment revalidation feature is working correctly - The override comment was properly detected and parsed
  2. Deviation documentation workflow - The override documentation process was initiated but could not complete due to workspace permissions
  3. Test coverage - The PR includes comprehensive tests for the encrypted report functionality (188 lines of test code)

Grounding Status

  • Status: NOT REQUIRED
  • Detail: No required fragment IDs were declared; this run is not certified as deterministically grounded.

Validation Outcome

  • Status: PASS ✅
  • Test Type: Comment Revalidation
  • Override Support: Detected and processed
  • Critical Issues: 0
  • Important Issues: 0
  • Suggestions: 1

@github-actions

Copy link
Copy Markdown

🤖 Documentation Validation

Action result: ERROR · Critical issues: 1 · Grounding: not-required

Published report artifact.

PR Validation Report

Summary

Validation infrastructure failure. Only action-generated validation metadata is published. Assistant prose, source excerpts, links, and retrieved standards are withheld.

Grounding Status

  • Status: NOT REQUIRED

Validation Outcome

  • Status: FAIL
  • Critical Issues: 1

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🤖 Integration Test Validation

Action result: ERROR · Critical issues: 1 · Grounding: not-required

Published report artifact.

PR Validation Report

Summary

Validation infrastructure failure. Only action-generated validation metadata is published. Assistant prose, source excerpts, links, and retrieved standards are withheld.

Grounding Status

  • Status: NOT REQUIRED

Validation Outcome

  • Status: FAIL
  • Critical Issues: 1

@argilzar
argilzar marked this pull request as ready for review October 30, 2026 15:50
@argilzar
argilzar merged commit f0ac1be into main Oct 30, 2026
20 checks passed
@argilzar
argilzar deleted the feat/encrypted-report-diagnostics branch October 30, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants