Repository navigation
Fix npm 11 lockfile validation for installer publishing - #50
Merged
Merged
Conversation
Record electron-builder's existing optional Windows-signing peer and its dependencies. npm 11 validates these entries during npm ci, so the installer publishing workflow failed before building even though npm 10 accepted the lockfile. Existing dependency versions and application source are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer publishing workflow uses npm 11, which rejected the lockfile because electron-builder's optional Windows-signing peer was absent. Record that existing peer and its transitive dependencies without changing application source or existing package versions. Validated with npm 11 ci dry-run, changed-file checks, and the normal commit/push gates.