feat(device_info_plus): Add support of built-in Kotlin#3889
Open
vbuberen wants to merge 2 commits into
Open
Conversation
vbuberen
force-pushed
the
feat/device_info_plus_kotlin
branch
from
437e231 to
396b362
Compare
This was referenced Jun 21, 2026
mdmahendri
reviewed
Jun 21, 2026
mdmahendri
left a comment
mdmahendri
left a comment
Contributor
There was a problem hiding this comment.
Just something I caught while testing the PR.
| @@ -1,6 +1,5 @@ | |||
| plugins { | |||
| id("com.android.application") | |||
| id("kotlin-android") | |||
Contributor
There was a problem hiding this comment.
So I just tested this PR locally using Flutter 3.38.1, and the build for the example failed.
The removal of the explicit kotlin-android plugin relies on the auto-apply behavior introduced in Flutter upstream via flutter/flutter#184227.
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching, but just sharing the link was enough. Such lectures are not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backwards compatible support of built-in Kotlin as per https://docs.flutter.dev/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors#supporting-flutter-versions-earlier-than-3-44
Additionally updated example app to not show warnings about versions of Gradle, Kotlin or NDK.
Related Issues
Closes #3835
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).