Skip to content

Fix master branch build - #8065

Merged
popojk merged 2 commits into
flyteorg:masterfrom
Sovietaced:master-build
Sep 22, 2026
Merged

popojk merged 2 commits into
flyteorg:masterfrom
Sovietaced:master-build

Conversation

@Sovietaced

@Sovietaced Sovietaced commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Why are the changes needed?

Master builds are failing.

What changes were proposed in this pull request?

  1. Pin buf
  2. Use a minio image that can be pulled
  3. Improve test assertions

How was this patch tested?

CI

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

@github-actions github-actions Bot added the flyte label Sep 21, 2026
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.29%. Comparing base (e2620f7) to head (5ecb68a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8065      +/-   ##
==========================================
- Coverage   57.29%   57.29%   -0.01%     
==========================================
  Files         931      931              
  Lines       58316    58316              
==========================================
- Hits        33413    33412       -1     
- Misses      21844    21845       +1     
  Partials     3059     3059              
Flag Coverage Δ
unittests-datacatalog 53.62% <ø> (ø)
unittests-flyteadmin 53.24% <ø> (ø)
unittests-flytecopilot 48.05% <ø> (ø)
unittests-flytectl 64.11% <ø> (ø)
unittests-flyteidl 76.63% <ø> (ø)
unittests-flyteplugins 60.45% <ø> (ø)
unittests-flytepropeller 53.84% <ø> (ø)
unittests-flytestdlib 64.39% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced Sovietaced added the fixed For any bug fixes label Sep 21, 2026
@Sovietaced Sovietaced changed the title Dummy change Fix master branch build Sep 21, 2026
@Sovietaced
Sovietaced marked this pull request as ready for review September 21, 2026 19:57
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@popojk
popojk merged commit f64fc4a into flyteorg:master Sep 22, 2026
105 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed For any bug fixes flyte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants