Repository navigation
fix: keep editor interactions inside the dialog - #83
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thedhanawada
marked this pull request as ready for review
October 2, 2026 07:37
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Actual Salesforce Lightning QA found that color selection and other composed shadow-DOM clicks were mistaken for backdrop clicks, dismissing New Event. Determine the dialog boundary from the composed event path without stopping propagation. Preserve genuine backdrop and explicit dismissal.
Datetime fields now use full rows within the 400px dialog; the body scrolls on short screens and colors can wrap, preventing input overflow.
Verification
Compatible patch release 1.8.1 through the existing release workflow.