Repository navigation
feat: [minor] add safe event details, editing and deletion - #85
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81, closes #74, closes #47 when reviewed and merged. Includes the verified equivalent of #84; keep #84 open until this consolidated PR lands.
Open calendar-owned, plain-DOM details before the editor from click/Enter/Space, showing title, clicked occurrence time, and location. Dynamic values use textContent. Times are explicitly labeled local, consistent with the existing grid.
Add Edit with prefilled title, location, all-day state, times and color; save updates the existing id instead of creating a duplicate, retaining host-owned metadata/attendees/description and the destination time zone supported by older Core releases.
Require an accessible delete confirmation, with Cancel/Escape, failure feedback and retry; retain failed save drafts and block stale edits after external data changes.
Scope keyboard/focus handling to the calendar, guard stale controls, restore visible/non-inert focus targets and release dialogs/traps on navigation, readOnly toggles, teardown and reattachment.
Preserve untouched full-precision dates and nullable colors, including sub-minute events and repeated DST hours. Range creation retains its selected end time.
Recurring details show the selected occurrence, but omit Edit/Delete and drag/resize mutation paths with a clear explanation. Recurrence is checked when arming gestures and again at move/up/commit, and unsupported resize handles are omitted. Series/occurrence mutation choice is intentionally deferred rather than silently editing the master.
Include fix: guard focus restoration and compile wildcard subscriptions #84 focus-restoration safety and subscription-scoped wildcard compilation.
Add
show-color-picker="false"/showColorPicker = falsefor hosts that cannot persist color; default remains visible, active drafts and existing colors are preserved.Recognize
metadata.forceCalendarRecurring === trueon externally expanded instances: display once without an RRULE and disable all built-in mutation controls. Standalone EventForm.edit also declines recurring entries; imperative host APIs remain unchanged.Use date-only Start date / Last day (inclusive) fields for all-day events, accepting same-day events while preserving Core’s existing inclusive civil-date contract. Timed/all-day toggles retain exact unchanged timed instants; no Core boundary change.
Validation
Review limits
No live Salesforce Locker/LWS or browser visual acceptance is claimed. The available deployed preview requires Vercel login and the cloud browser blocks localhost. The implementation avoids a new custom-element registration, portals and native Popover APIs, but live integration, assistive technology and visual testing remain review gates.
Draft only. No merge, package version change, release or installer pin update. This is a minor feature release (1.9.0 from 1.8.1); preserve [minor] in the eventual merge/squash commit message. Live candidate acceptance remains required before release.