Skip to content

fix: honor configured week start in calendar title - #86

Merged
thedhanawada merged 1 commit into
masterfrom
fix/week-title-start-day
Oct 2, 2026
Merged

thedhanawada merged 1 commit into
masterfrom
fix/week-title-start-day

Conversation

@thedhanawada

Copy link
Copy Markdown
Contributor

What changed

The week header now passes the configured weekStartsOn to both date boundary helpers. With a Monday-start calendar on October 2, 2026, the header now shows September 28–October 4, matching the grid and getVisibleRange().

Why

The grid respected week-starts-on, but the header always used Sunday boundaries. This caused the displayed range to disagree with the dates in the calendar.

Test plan

  • Existing tests pass (npm test -- --runInBand): 20 suites, 298 tests, including generated declarations and TypeScript consumer checks.
  • Seven regression cases cover default/explicit Sunday starts, Monday starts, month/year boundaries, and changing the week start plus German locale after mount. The four Monday-related cases failed before the fix and pass afterward.
  • Tests verify the rendered title, visible range, and first/last grid columns together.
  • Production build, source Prettier check, and ESLint pass (0 errors; 12 existing warnings).
  • Browser verification after the package is released and consumed by the website.

Breaking changes

None. No version bump or release is included.

@vercel

vercel Bot commented Oct 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
force-calendar-interface Ready Ready Preview Oct 2, 2026 1:44pm UTC

@thedhanawada
thedhanawada marked this pull request as ready for review October 2, 2026 14:10
@thedhanawada
thedhanawada merged commit d2f5749 into master Oct 2, 2026
12 checks passed

This branch was successfully deployed

1 active deployment
Preview — 9b46615d Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant