Repository navigation
fix: show the signed-in account profile in rooms and chat views - #348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-in accounts could show Somebody even when the account’s kind-0 profile had loaded: account metadata and the room’s profile map were separate, the separate chat view copied account details only once, and the directory preference also gated the account’s own metadata.
Load the signed-in account’s profile while Nostr account networking is enabled, independently of optional directory lookups for other people. Carry the verified own profile/name into room state and observe late metadata in the borrowed chat account. Keep learned own names local when networking pauses, and keep account replacement, anonymous/nearby rooms and private-mode boundaries intact. Retry missing kind-0 reads twice with bounded windows and the caller’s account/network lifetime. Clarify the settings labels.
Validation: the application compiles, and all 11 focused profile lookup, account relay selection and room-title tests pass locally (in-process Kotlin compiler). Tests cover recovering a timed-out profile, retrying only missing authors, bounded permanent misses, cancelling retries on mode/account changes, keeping the own name with directory lookups off, and excluding different accounts and anonymous/nearby profile reads. Hosted CI remains required before merge. No physical handset or actual signer was operated.
This changes standalone KithMoot screens; no Archipelago integration is changed. Publication and physical device acceptance are separate from source qualification.