Repository navigation
fix: prevent replay of consumed verification values - #10
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 5
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumed verification values can be reinserted when a transaction removes a managed entity from the identity map and a later parent-context write flushes it. This allows a consumed value to become usable again before expiry. Read the consumption snapshot with
disableIdentityMap: trueand removeunsetIdentity, while retaining the guarded delete and affected-row check.Add PostgreSQL regression coverage for later writes, transaction/parent-context flushes, and two racing consumers; run it in the CI matrix. Include a patch changeset.
Validation: reproduced the transaction regression against unmodified source on MikroORM 7.1.8 and 7.2.1. Fixed PostgreSQL tests pass on both; full suite on 7.1.8 passes (114 passed, 36 skipped), and package build passes. Standalone test typechecking has a pre-existing cast error in the sealed-secret fixture.
Need help on this PR? Tag
@codesmith-botwith what you need.