Fix few resource leaks, uninitialized vars, and error paths#850
Merged
Conversation
These small issues are reported by the cppcheck static analyzer; with these changes, cppcheck is happy.
Contributor
Author
|
I've also converted some 0 into NULL in the few places I've touched, if you don't mind. |
|
coverage: 63.144% (-0.02%) from 63.164% — magv:cppcheck into form-dev:master |
tueda
approved these changes
Jun 24, 2026
tueda
left a comment
tueda
left a comment
Collaborator
There was a problem hiding this comment.
These are indeed improvements. Thanks!
Though it doesn't matter because FORM exits anyway sooner or later in these error paths, it seems that there are more resource leaks around the code you improved. Would you like to address them in this PR as well? Or a separate PR? (Then we'll have another competition in the workshop.)
Contributor
Author
|
No, I think I'm satisfied with this one. Other changes will be separate pull requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These small issues are reported by the cppcheck static analyzer; with these changes, cppcheck is happy.