Skip to content

Some GraphicalDisplayRenderer methods are private and should be at least protected #431

Description

@clarencelocke

What happened?

I am creating a custom GraphicalDisplayRenderer subclass and have found that I cannot access certain geometry information because the methods are private.

I believe all of the following should be at least protected access:

uint8_t measureText(const char* text) const;
uint8_t toggleIndicatorWidth() const;
uint8_t rowHeight() const;
void drawScrollBar();

uint8_t getMaxRows() const override;
uint8_t getMaxCols() const override;
uint8_t getEffectiveCols() const override;

Version

  • I have checked that I am using the latest version of the library.

forntoh/LcdMenu@^5.13.0

What environment are you seeing the problem in?

Platform IO

Board type

N/A

Relevant log output

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions