Skip to content

feat: add page numbers to energy_terms and apply the paper-dictionary review - #51

Merged
forzagreen merged 2 commits into
mainfrom
feat/energy-terms-pages-review
Sep 20, 2026
Merged

forzagreen merged 2 commits into
mainfrom
feat/energy-terms-pages-review

Conversation

@forzagreen

Copy link
Copy Markdown
Owner

Summary

energy_terms (معجم مصطلحات الطاقة, Q141133750) was imported from Siwar without page numbers. A reviewer checked all 1575 terms against the printed dictionary; this PR applies that review.

Action Rows
page set (range 10-185) 1550
Term text corrected to match the printed dictionary 36
Duplicate rows removed 6
Left unchanged: absent from the printed edition (غير موجود / محذوف) 18
Left unchanged: no page and no comment from the reviewer (558572 Light Trucks) 1

nbr_entries: 1575 -> 1569. updated_at is set on every changed term and on the dictionary row.

Removed rows

Five were flagged as duplicates by the reviewer; the twin that carries the page number is kept.

Removed Kept
558243 Reverse Osmosis Technology (RO) 558241
558430 Production Line 558424
558741 Liquefied Petroleum Gas (LPG) 558705
558969 Heavy-Duty Vehicles (HDVs) 558967 Heavy Duty Vehicles (HDVS)
559138 Billion Cubic Feet 559137 Billion Cubic Feet (BCF)

The sixth, 558771 Production Capacity, was not flagged as a duplicate: the reviewer corrected its Arabic from قدرة إنتاجية to سعة إنتاجية, which makes it identical (English, Arabic and page 23) to 558543, so only 558543 is kept.

Corrected terms

24 rows are flagged معدل / الإنجليزي غير مطابق; 12 more were edited by the reviewer without a comment (e.g. the تصريف -> تخلص series for Disposal, ترخيص -> إذن for Authorization). Both groups are applied. English changes: 558431, 558769, 558859, 559104, 559158, 559165.

Six of the reviewer's edits contained an obvious typo, fixed here rather than copied verbatim — worth a second look against the paper:

id In the spreadsheet Stored
558171 أذن إذن
558280 اتزان التحلل الإشعاي اتزان التحلل الإشعاعي
558552 سلامة البئروتكامله سلامة البئر وتكامله
558876 المواد المشعة طبيعية المنشا المواد المشعة طبيعية المنشأ
559104 المعيارالسعودي لاقتصاد الوقود المعيار السعودي لاقتصاد الوقود
559134 مكمن الغاز وآباه مكمن الغاز وآباره

Stray whitespace (double / trailing spaces) in 558682, 559104 and 559134 is also normalised.

Verification

  • make regenerate_dumps ran end to end: make validate passes with an unchanged baseline, the FULLTEXT smoke test returns results, and MariaDB holds 1569 rows for the dictionary, 1550 of them with a page.
  • Both dumps are regenerated, so the Wikitermbase notification will fire on merge.

… review

Review of energy_terms (Q141133750) against the printed dictionary:
- set the page of 1550 terms
- correct 36 terms to match the printed wording
- remove 6 duplicate rows (nbr_entries 1575 -> 1569)
- keep as is the 18 terms that are absent from the printed edition
It was the only dictionary whose nbr_entries differed from its real term
count; the violation leaves the validation baseline.
@forzagreen

Copy link
Copy Markdown
Owner Author

Added a second commit: nbr_entries was checked against the real term count for all 84 dictionaries. The only mismatch was al_mawrid_al_hadeeth (62266 declared, 62265 real) — fixed, and removed from validation_baseline.json, so dictionary_nbr_entries_mismatch is now 0 found / 0 in baseline. The website is unaffected: it displays COUNT(term), never the stored nbr_entries.

@forzagreen
forzagreen merged commit 827f00a into main Sep 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant