feat: add page numbers to energy_terms and apply the paper-dictionary review - #51
Merged
Merged
Conversation
… review Review of energy_terms (Q141133750) against the printed dictionary: - set the page of 1550 terms - correct 36 terms to match the printed wording - remove 6 duplicate rows (nbr_entries 1575 -> 1569) - keep as is the 18 terms that are absent from the printed edition
It was the only dictionary whose nbr_entries differed from its real term count; the violation leaves the validation baseline.
Owner
Author
|
Added a second commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
energy_terms(معجم مصطلحات الطاقة, Q141133750) was imported from Siwar without page numbers. A reviewer checked all 1575 terms against the printed dictionary; this PR applies that review.pageset (range 10-185)غير موجود/محذوف)558572Light Trucks)nbr_entries: 1575 -> 1569.updated_atis set on every changed term and on the dictionary row.Removed rows
Five were flagged as duplicates by the reviewer; the twin that carries the page number is kept.
The sixth, 558771
Production Capacity, was not flagged as a duplicate: the reviewer corrected its Arabic fromقدرة إنتاجيةtoسعة إنتاجية, which makes it identical (English, Arabic and page 23) to 558543, so only 558543 is kept.Corrected terms
24 rows are flagged
معدل/الإنجليزي غير مطابق; 12 more were edited by the reviewer without a comment (e.g. theتصريف->تخلصseries for Disposal,ترخيص->إذنfor Authorization). Both groups are applied. English changes: 558431, 558769, 558859, 559104, 559158, 559165.Six of the reviewer's edits contained an obvious typo, fixed here rather than copied verbatim — worth a second look against the paper:
Stray whitespace (double / trailing spaces) in 558682, 559104 and 559134 is also normalised.
Verification
make regenerate_dumpsran end to end:make validatepasses with an unchanged baseline, the FULLTEXT smoke test returns results, and MariaDB holds 1569 rows for the dictionary, 1550 of them with a page.