fix(website): add the missing @emnapi peers to package-lock.json - #54
Merged
Merged
Conversation
The gh-pages build failed at `npm ci` after #53: Missing: @emnapi/core@1.11.3 from lock file Missing: @emnapi/wasi-threads@1.2.3 from lock file The lockfile was written by npm 11.5.1, which does not record the peer dependencies of the optional @napi-rs/wasm-runtime that Astro 7 pulls in. The runner has npm 11.19.0, which requires them. Regenerated with npm 11.19.0; no package version changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the GitHub Pages deploy, which has failed at
npm cisince #53 (run):Cause
Astro 7 pulls in the optional
@napi-rs/wasm-runtime, which has peer dependencies on@emnapi/coreand@emnapi/wasi-threads. The lockfile in #53 was written by npm 11.5.1, which does not record those peers. The runner has npm 11.19.0, which treats the lockfile as out of sync without them.npm ciwas checked locally in #53, but with npm 11.5.1, so it passed.Fix
Regenerated
package-lock.jsonwith npm 11.19.0 (npx npm@11.19.0 install --package-lock-only). It adds 23 lines for the two packages; no package version changes,npm auditstill reports 0 vulnerabilities.Verification
npx npm@11.19.0 ci, and it passes after the changenpm cialso still passes with npm 11.5.1npm run buildfrom the npm 11.19.0 install: 593 pages, 678 files, same as beforenpm 11.19.0 also warns that the install scripts of
better-sqlite3,esbuildandfseventsare not covered byallowScripts, and does not run them. That is harmless here:better-sqlite313 ships alinux-x64prebuild inside the package, and the esbuild Linux binary is its own lockfile entry. Both load without their scripts.This workflow only runs on
main, so the deploy itself is first exercised on merge.