Repository navigation
site service: add --config-file support - #149
Merged
oschwartz10612 merged 1 commit intoSep 23, 2026
Merged
Conversation
Pass --config-file through to the service as CONFIG_FILE (resolved to an absolute path, since the service runs from a different cwd). When it is set, --id/--secret/--endpoint become optional; any given still override the file via the env layer. Only non-empty values are written into the service environment.
itsjxck
requested review from
miloschwartz and
oschwartz10612
as code owners
September 23, 2026 11:53
Member
|
Thanks so much! |
oschwartz10612
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
AI Disclosure
Claude Fable 5.1 was used to make this change
Description
Pass
--config-filethrough to the service asCONFIG_FILE(resolved to an absolute path, since the service can run from a different working directory). When it is set,--id/--secret/--endpointbecome optional; any given flag from that set will still override the config file's value due to env vars being applied after loading config gile in newt. Only non-empty values are written into the service environment.How to test?
Verifies that
--config-fileis passed through to the service and that--id/--secret/--endpointare no longer required when it is set. No real Pangolin server needed.make buildExpected: repeated
Failed to connect ... https://invalid.example.test ... no such host— that endpoint exists only in the config file, so it must have been loaded viaCONFIG_FILE.5. Clean up:
sudo pangolin service uninstall site && rm -rf /tmp/pgtest