Improve the way we create a base page context#202
Merged
Merged
Conversation
vkhoroz
approved these changes
Jul 12, 2026
| CsrfToken: csrfToken, | ||
| Version: version.Version, | ||
| } | ||
| return h.pages.Base(c, title, selected) |
Member
There was a problem hiding this comment.
Just to clarify on the commit message: we were usually breaking the auth pages, not literally "every page" when introducing new base context fields, right?
We've had this split where the auth package and UI package have their own logic for creating this base page context. Every time we've added a new field, this time its branding stuff, we've broken some page's rendering logic. This change introduces logic to consolidate things and fights circular dependencies. Signed-off-by: Andy Doan <doanac@qti.qualcomm.com> Co-authored-by: GitHub Copilot:claude-opus-4.8 <noreply@github.com>
Member
Author
|
rebased on latest main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had this split where the auth package and UI package have their own logic for creating this base page context.
Every time we've added a new field, this time its branding stuff, we've broken some page's rendering logic. This change introduces logic to consolidate things and fights circular dependencies.
There are even better ways this could be done. However, this is the least invasive way and probably serves the size of our code well enough to survive with for the foreseeable future.