Repository navigation
fix(compilers): use deployed bytecode in hardhat conversion - #263
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ara-stock
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg and
stevencartavia
as code owners
October 19, 2026 01:57
figtracer
reviewed
Oct 19, 2026
figtracer
approved these changes
Oct 19, 2026
stevencartavia
approved these changes
Oct 19, 2026
figtracer
enabled auto-merge (squash)
October 19, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
impl From<HardhatArtifact> for ContractBytecodebuildsdeployed_bytecodefromartifact.bytecodeinstead ofartifact.deployed_bytecode. The converted contract's runtime bytecode is the creation bytecode (with the deployed link references attached), and a Hardhat artifact'sdeployedBytecodeis dropped. This also affects theCompactContractBytecodeandCompactContractBytecodeCowconversions, which go throughContractBytecode.Fix
Use
artifact.deployed_bytecodefordeployed_bytecode, asFrom<HardhatArtifact> for CompactContractalready does.Test
Added
hh::tests::hardhat_artifact_into_contract_bytecode, which converts an artifact with different creation and runtime bytecode and checks both. Before the fix, it fails because the deployed bytecode is6080600052instead of6001600055.This PR was written with help from Claude Code. I reviewed the change and ran the tests locally.
🤖 Generated with Claude Code