Repository navigation
fix: Handle error replies to noray connect command - #666
Open
armadavalor wants to merge 1 commit into
Open
armadavalor wants to merge 1 commit into
armadavalor wants to merge 1 commit into
Conversation
When noray can't connect two peers, e.g. because the host OID is unknown, it replies with a `connect` command whose payload is an error message instead of an address. The handler indexed the split result unconditionally, which crashed. Log the error and skip emitting `on_connect_nat` instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When noray can't connect two peers, e.g. because the host OID is unknown, it replies with a
connectcommand whose payload is an error message (connect AssertionError: Unknown host oid: ...) instead of an address._handle_commands()indexedparts[1]of the split payload unconditionally, soNoray.connect_nat("invalid_game_id")crashed with an invalid index access.The handler now checks that the payload is
host:port, logs an error otherwise, and does not emiton_connect_nat.Tested: read through the noray server source to confirm the reply format. Not run in Godot, no automated test added.
Closes #619